diff --git a/src/Services/EventReportService.cpp b/src/Services/EventReportService.cpp index d7ecd8b157ae8ed165705beda84d1b3848ece994..4db2cca4feec5693e665ff125ad5e3431b82d332 100644 --- a/src/Services/EventReportService.cpp +++ b/src/Services/EventReportService.cpp @@ -1,7 +1,10 @@ #include <Services/EventReportService.hpp> #include "Services/EventReportService.hpp" #include "Message.hpp" - +/** + * + * @todo: this code is error prone, depending on parameters given, add fail safes + */ void EventReportService::informativeEventReport(Event eventID, const uint8_t *data, uint8_t length) { // TM[5,1] diff --git a/test/Services/EventReportService.cpp b/test/Services/EventReportService.cpp index 32f4f30b18ee8d9e38c9c5a059fcfd07ad27c9f1..ad14befc429fa3c222d26332fa6d3b060618dcbf 100644 --- a/test/Services/EventReportService.cpp +++ b/test/Services/EventReportService.cpp @@ -42,7 +42,7 @@ TEST_CASE("Low Severity Anomaly Report TM[5,2]", "[service][st05]") { CHECK(report.packetType == Message::TM); // packet type(TM = 0, TC = 1) REQUIRE(report.dataSize == 12); // Check for the value that is stored in <<data>> array(data-member of object response) - CHECK(report.readEnum16() == 1); + CHECK(report.readEnum16() == 4); report.readString(checkString, 10); CHECK(strcmp(checkString, reinterpret_cast<const char *>(eventReportData)) == 0); } @@ -62,7 +62,7 @@ TEST_CASE("Medium Severity Anomaly Report TM[5,3]", "[service][st05]") { CHECK(report.packetType == Message::TM); // packet type(TM = 0, TC = 1) REQUIRE(report.dataSize == 12); // Check for the value that is stored in <<data>> array(data-member of object response) - CHECK(report.readEnum16() == 2); + CHECK(report.readEnum16() == 5); report.readString(checkString, 10); CHECK(strcmp(checkString, reinterpret_cast<const char *>(eventReportData)) == 0); } @@ -82,7 +82,7 @@ TEST_CASE("High Severity Anomaly Report TM[5,4]", "[service][st05]") { CHECK(report.packetType == Message::TM); // packet type(TM = 0, TC = 1) REQUIRE(report.dataSize == 12); // Check for the value that is stored in <<data>> array(data-member of object response) - CHECK(report.readEnum16() == 3); + CHECK(report.readEnum16() == 6); report.readString(checkString, 10); CHECK(strcmp(checkString, reinterpret_cast<const char *>(eventReportData)) == 0); }