From 1582db4557dc236d5237fcf7807a1ae2da4f2b30 Mon Sep 17 00:00:00 2001
From: athatheocsd <athatheo@csd.auth.gr>
Date: Sun, 2 Dec 2018 19:49:52 +0200
Subject: [PATCH] comments added and tests changed
---
src/Services/EventReportService.cpp | 5 ++++-
test/Services/EventReportService.cpp | 6 +++---
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/src/Services/EventReportService.cpp b/src/Services/EventReportService.cpp
index d7ecd8b1..4db2cca4 100644
--- a/src/Services/EventReportService.cpp
+++ b/src/Services/EventReportService.cpp
@@ -1,7 +1,10 @@
#include <Services/EventReportService.hpp>
#include "Services/EventReportService.hpp"
#include "Message.hpp"
-
+/**
+ *
+ * @todo: this code is error prone, depending on parameters given, add fail safes
+ */
void EventReportService::informativeEventReport(Event eventID, const uint8_t *data,
uint8_t length) {
// TM[5,1]
diff --git a/test/Services/EventReportService.cpp b/test/Services/EventReportService.cpp
index 32f4f30b..ad14befc 100644
--- a/test/Services/EventReportService.cpp
+++ b/test/Services/EventReportService.cpp
@@ -42,7 +42,7 @@ TEST_CASE("Low Severity Anomaly Report TM[5,2]", "[service][st05]") {
CHECK(report.packetType == Message::TM); // packet type(TM = 0, TC = 1)
REQUIRE(report.dataSize == 12);
// Check for the value that is stored in <<data>> array(data-member of object response)
- CHECK(report.readEnum16() == 1);
+ CHECK(report.readEnum16() == 4);
report.readString(checkString, 10);
CHECK(strcmp(checkString, reinterpret_cast<const char *>(eventReportData)) == 0);
}
@@ -62,7 +62,7 @@ TEST_CASE("Medium Severity Anomaly Report TM[5,3]", "[service][st05]") {
CHECK(report.packetType == Message::TM); // packet type(TM = 0, TC = 1)
REQUIRE(report.dataSize == 12);
// Check for the value that is stored in <<data>> array(data-member of object response)
- CHECK(report.readEnum16() == 2);
+ CHECK(report.readEnum16() == 5);
report.readString(checkString, 10);
CHECK(strcmp(checkString, reinterpret_cast<const char *>(eventReportData)) == 0);
}
@@ -82,7 +82,7 @@ TEST_CASE("High Severity Anomaly Report TM[5,4]", "[service][st05]") {
CHECK(report.packetType == Message::TM); // packet type(TM = 0, TC = 1)
REQUIRE(report.dataSize == 12);
// Check for the value that is stored in <<data>> array(data-member of object response)
- CHECK(report.readEnum16() == 3);
+ CHECK(report.readEnum16() == 6);
report.readString(checkString, 10);
CHECK(strcmp(checkString, reinterpret_cast<const char *>(eventReportData)) == 0);
}
--
GitLab