From 26dd579911a66cb9d8415b697fd50eeaafcf25ca Mon Sep 17 00:00:00 2001
From: kpetridis <petridkon@gmail.com>
Date: Sun, 3 Apr 2022 22:06:28 +0300
Subject: [PATCH] Removed comment
---
inc/Helpers/ForwardControlConfiguration.hpp | 2 --
src/Services/RealTimeForwardingControlService.cpp | 2 --
test/Services/RealTimeForwardingControl.cpp | 4 ++++
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/inc/Helpers/ForwardControlConfiguration.hpp b/inc/Helpers/ForwardControlConfiguration.hpp
index 353a481b..9ac00bef 100644
--- a/inc/Helpers/ForwardControlConfiguration.hpp
+++ b/inc/Helpers/ForwardControlConfiguration.hpp
@@ -35,8 +35,6 @@ public:
*/
etl::map<uint8_t, reportsAreNotEmpty, ECSSMaxControlledApplications> serviceNotEmpty;
-// etl::map<uint8_t, bool, ECSSMaxControlledApplications> serviceOfAppNotEmpty;
-
/**
* Vector containing the Report Type definitions. Each definition has its unique name of type uint8. For
* example, a Report Type definition could be 'ReportHousekeepingStructures'.
diff --git a/src/Services/RealTimeForwardingControlService.cpp b/src/Services/RealTimeForwardingControlService.cpp
index 03bb89d1..98d61e43 100644
--- a/src/Services/RealTimeForwardingControlService.cpp
+++ b/src/Services/RealTimeForwardingControlService.cpp
@@ -99,7 +99,6 @@ void RealTimeForwardingControlService::addReportTypesToAppProcessConfiguration(M
}
if (numOfServices == 0) {
- // todo: add all report types of the application process to the configuration.
applicationProcessConfiguration.definitions[applicationID].clear();
continue;
}
@@ -114,7 +113,6 @@ void RealTimeForwardingControlService::addReportTypesToAppProcessConfiguration(M
}
if (numOfMessages == 0) {
- // todo: add all report types of the service type to the configuration.
applicationProcessConfiguration.definitions[applicationID][serviceType].clear();
continue;
}
diff --git a/test/Services/RealTimeForwardingControl.cpp b/test/Services/RealTimeForwardingControl.cpp
index fb92846a..32570d23 100644
--- a/test/Services/RealTimeForwardingControl.cpp
+++ b/test/Services/RealTimeForwardingControl.cpp
@@ -506,6 +506,10 @@ TEST_CASE("Add report types to the Application Process Configuration") {
CHECK(ServiceTests::count() == 1);
CHECK(ServiceTests::countThrownErrors(ErrorHandler::ExecutionStartErrorType::NotControlledApplication) == 1);
auto& applicationProcesses = realTimeForwarding.applicationProcessConfiguration.definitions;
+
+ REQUIRE(applicationProcesses.find(applicationID1) != applicationProcesses.end());
+ REQUIRE(applicationProcesses.find(applicationID2) != applicationProcesses.end());
+ REQUIRE(applicationProcesses.find(3) == applicationProcesses.end());
REQUIRE(applicationProcesses[applicationID1].empty());
REQUIRE(applicationProcesses[applicationID2].empty());
--
GitLab