From 38fbf7451fb655fe584f066cc43ed5106503dc49 Mon Sep 17 00:00:00 2001
From: kongr45gpen <electrovesta@gmail.com>
Date: Thu, 21 Mar 2019 19:35:19 +0200
Subject: [PATCH] Fix the build for clang-tidy
---
ci/.clang-tidy | 2 +-
src/Services/EventActionService.cpp | 3 +--
src/Services/EventReportService.cpp | 2 +-
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/ci/.clang-tidy b/ci/.clang-tidy
index d6611e01..38beddf8 100644
--- a/ci/.clang-tidy
+++ b/ci/.clang-tidy
@@ -19,7 +19,7 @@ Checks: >
performance-*,
readability-*,
zircon-*
-WarningsAsErrors: '*,-misc-unused-parameters,-llvm-header-guard,-cppcoreguidelines-pro-type-member-init,-google-runtime-references,-clang-diagnostic-tautological-constant-out-of-range-compare,-readability-redundant-declaration',-modernize-use-equals-default,-fuchsia-statically-constructed-objects,-hicpp-signed-bitwise,-cert-err58-cpp',-clang-diagnostic-error,-misc-noexcept-move-constructor'
+WarningsAsErrors: '*,-misc-unused-parameters,-llvm-header-guard,-cppcoreguidelines-pro-type-member-init,-google-runtime-references,-clang-diagnostic-tautological-constant-out-of-range-compare,-readability-redundant-declaration,-modernize-use-equals-default,-fuchsia-statically-constructed-objects,-hicpp-signed-bitwise,-cert-err58-cpp,-clang-diagnostic-error,-misc-noexcept-move-constructor'
HeaderFilterRegex: 'ecss-services\/((?!lib\/).)*$'
AnalyzeTemporaryDtors: false
...
diff --git a/src/Services/EventActionService.cpp b/src/Services/EventActionService.cpp
index 92d7055d..e33ff714 100644
--- a/src/Services/EventActionService.cpp
+++ b/src/Services/EventActionService.cpp
@@ -191,8 +191,7 @@ void EventActionService::executeAction(uint16_t eventID) {
if (eventActionFunctionStatus) {
for (uint16_t i = 0; i < ECSS_EVENT_ACTION_STRUCT_ARRAY_SIZE; i++) {
if (not eventActionDefinitionArray[i].empty &&
- eventActionDefinitionArray[i].enabled ==
- true) {
+ eventActionDefinitionArray[i].enabled) {
if (eventActionDefinitionArray[i].eventDefinitionID == eventID) {
MessageParser messageParser;
Message message = messageParser.parseRequestTC(
diff --git a/src/Services/EventReportService.cpp b/src/Services/EventReportService.cpp
index 162b4b23..b86a017c 100644
--- a/src/Services/EventReportService.cpp
+++ b/src/Services/EventReportService.cpp
@@ -125,7 +125,7 @@ void EventReportService::listOfDisabledEventsReport() {
uint16_t numberOfDisabledEvents = stateOfEvents.size() - stateOfEvents.count();
report.appendHalfword(numberOfDisabledEvents);
for (uint16_t i = 0; i < stateOfEvents.size(); i++) {
- if (stateOfEvents[i] == 0) {
+ if (not stateOfEvents[i]) {
report.appendEnum16(i);
}
}
--
GitLab