From 618b70bd7ae1c1f87c1424b7d6750cbebcb32906 Mon Sep 17 00:00:00 2001
From: kongr45gpen <electrovesta@gmail.com>
Date: Sun, 18 Nov 2018 18:34:04 +0200
Subject: [PATCH] Implement code review comments
---
tests/Services/ServiceTests.hpp | 4 ++--
tests/TestPlatform.cpp | 4 ----
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/tests/Services/ServiceTests.hpp b/tests/Services/ServiceTests.hpp
index f84e2dc6..a160558a 100644
--- a/tests/Services/ServiceTests.hpp
+++ b/tests/Services/ServiceTests.hpp
@@ -17,7 +17,7 @@ public:
* Get a message from the list of queued messages to send
* @param number The number of the message, starting from 0 in chronological order
*/
- static Message &get(unsigned long number) {
+ static Message &get(uint64_t number) {
return queuedMessages.at(number);
}
@@ -31,7 +31,7 @@ public:
/**
* Counts the number of messages in the queue
*/
- static unsigned long count() {
+ static uint64_t count() {
return queuedMessages.size();
}
diff --git a/tests/TestPlatform.cpp b/tests/TestPlatform.cpp
index 5282535c..10f9cdf3 100644
--- a/tests/TestPlatform.cpp
+++ b/tests/TestPlatform.cpp
@@ -14,10 +14,6 @@ void Service::storeMessage(const Message &message) {
struct ServiceTestsListener : Catch::TestEventListenerBase {
using TestEventListenerBase::TestEventListenerBase; // inherit constructor
- void testCaseStarting(Catch::TestCaseInfo const &testInfo) override {
- // Perform some setup before a test case is run
- }
-
void testCaseEnded(Catch::TestCaseStats const &testCaseStats) override {
// Tear-down after a test case is run
ServiceTests::reset();
--
GitLab