diff --git a/inc/ErrorHandler.hpp b/inc/ErrorHandler.hpp index 0fc021edd5467b51c8d4b035b44668351bdb8612..2d829c4ef399f92aa749232757b05ee83f421437 100644 --- a/inc/ErrorHandler.hpp +++ b/inc/ErrorHandler.hpp @@ -113,6 +113,7 @@ public: * This enumeration type corresponds with reports about the progress of the execution * of a request. For example if the execution of a request is a long process, then we can divide * the process into steps and take feedback that depends on the step identifier + * * @todo configure step ID for the suitable requests */ enum stepID { diff --git a/inc/Services/RequestVerificationService.hpp b/inc/Services/RequestVerificationService.hpp index 8da73dd3874546de8346d6187bb2a513248b6281..6a8f720e22eac20a986f87a61910ce8f138dc31b 100644 --- a/inc/Services/RequestVerificationService.hpp +++ b/inc/Services/RequestVerificationService.hpp @@ -69,6 +69,7 @@ public: * @param request Contains the necessary data to send the report. * The data is actually some data members of Message that contain the basic info * of the telecommand packet that its progress of execution is successful + * @param step Step identifier */ void successProgressExecutionVerification(const Message &request, ErrorHandler::stepID step); @@ -79,6 +80,7 @@ public: * The data is actually some data members of Message that contain the basic info * of the telecommand packet that its progress of execution has failed * @param errorCode The cause of creating this type of report + * @param step Step identifier */ void failProgressExecutionVerification(const Message &request, ErrorHandler::ProgressExecutionErrorType errorCode, ErrorHandler::stepID step); diff --git a/src/Services/RequestVerificationService.cpp b/src/Services/RequestVerificationService.cpp index 8b001216c5d20bfa04060bad709ec18d6e723d95..c936c5822624b044a953de7a96a61b14ed5b6a9f 100644 --- a/src/Services/RequestVerificationService.cpp +++ b/src/Services/RequestVerificationService.cpp @@ -10,7 +10,7 @@ void RequestVerificationService::successAcceptanceVerification(const Message &re report.appendEnumerated(1, request.packetType); // packet type report.appendBits(1, 0); // secondary header flag(not implemented) report.appendEnumerated(11, request.applicationId); // application process ID - report.appendEnumerated(2, ECSS_SEQUENCE_FLAGS); // sequence flags(not implemented) + report.appendEnumerated(2, ECSS_SEQUENCE_FLAGS); // sequence flags report.appendBits(14, 0); // packet sequence count(not implemented) storeMessage(report); @@ -27,7 +27,7 @@ RequestVerificationService::failAcceptanceVerification(const Message &request, report.appendEnumerated(1, request.packetType); // packet type report.appendBits(1, 0); // secondary header flag(not implemented) report.appendEnumerated(11, request.applicationId); // application process ID - report.appendEnumerated(2, ECSS_SEQUENCE_FLAGS); // sequence flags(not implemented) + report.appendEnumerated(2, ECSS_SEQUENCE_FLAGS); // sequence flags report.appendBits(14, 0); // packet sequence count(not implemented) report.appendEnum16(errorCode); // error code @@ -43,7 +43,7 @@ void RequestVerificationService::successStartExecutionVerification(const Message report.appendEnumerated(1, request.packetType); // packet type report.appendBits(1, 0); // secondary header flag(not implemented) report.appendEnumerated(11, request.applicationId); // application process ID - report.appendEnumerated(2, ECSS_SEQUENCE_FLAGS); // sequence flags(not implemented) + report.appendEnumerated(2, ECSS_SEQUENCE_FLAGS); // sequence flags report.appendBits(14, 0); // packet sequence count storeMessage(report); @@ -59,7 +59,7 @@ void RequestVerificationService::failStartExecutionVerification(const Message &r report.appendEnumerated(1, request.packetType); // packet type report.appendBits(1, 0); // secondary header flag(not implemented) report.appendEnumerated(11, request.applicationId); // application process ID - report.appendEnumerated(2, ECSS_SEQUENCE_FLAGS); // sequence flags(not implemented) + report.appendEnumerated(2, ECSS_SEQUENCE_FLAGS); // sequence flags report.appendBits(14, 0); // packet sequence count(not implemented) report.appendEnum16(errorCode); // error code @@ -76,7 +76,7 @@ void RequestVerificationService::successProgressExecutionVerification(const Mess report.appendEnumerated(1, request.packetType); // packet type report.appendBits(1, 0); // secondary header flag(not implemented) report.appendEnumerated(11, request.applicationId); // application process ID - report.appendEnumerated(2, ECSS_SEQUENCE_FLAGS); // sequence flags(not implemented) + report.appendEnumerated(2, ECSS_SEQUENCE_FLAGS); // sequence flags report.appendBits(14, 0); // packet sequence count(not implemented) report.appendEnum16(step); // step ID @@ -93,7 +93,7 @@ void RequestVerificationService::failProgressExecutionVerification(const Message report.appendEnumerated(1, request.packetType); // packet type report.appendBits(1, 0); // secondary header flag(not implemented) report.appendEnumerated(11, request.applicationId); // application process ID - report.appendEnumerated(2, ECSS_SEQUENCE_FLAGS); // sequence flags(not implemented) + report.appendEnumerated(2, ECSS_SEQUENCE_FLAGS); // sequence flags report.appendBits(14, 0); // packet sequence count(not implemented) report.appendEnum16(step); // step ID report.appendEnum16(errorCode); // error code @@ -110,7 +110,7 @@ void RequestVerificationService::successCompletionExecutionVerification(const Me report.appendEnumerated(1, request.packetType); // packet type report.appendBits(1, 0); // secondary header flag(not implemented) report.appendEnumerated(11, request.applicationId); // application process ID - report.appendEnumerated(2, ECSS_SEQUENCE_FLAGS); // sequence flags(not implemented) + report.appendEnumerated(2, ECSS_SEQUENCE_FLAGS); // sequence flags report.appendBits(14, 0); // packet sequence count(not implemented) storeMessage(report); @@ -127,7 +127,7 @@ RequestVerificationService::failCompletionExecutionVerification(const Message &r report.appendEnumerated(1, request.packetType); // packet type report.appendBits(1, 0); // secondary header flag(not implemented) report.appendEnumerated(11, request.applicationId); // application process ID - report.appendEnumerated(2, ECSS_SEQUENCE_FLAGS); // sequence flags(not implemented) + report.appendEnumerated(2, ECSS_SEQUENCE_FLAGS); // sequence flags report.appendBits(14, 0); // packet sequence count(not implemented) report.appendEnum16(errorCode); // error code @@ -145,7 +145,7 @@ RequestVerificationService::failRoutingVerification(const Message &request, report.appendEnumerated(1, request.packetType); // packet type report.appendBits(1, 0); // secondary header flag(not implemented) report.appendEnumerated(11, request.applicationId); // application process ID - report.appendEnumerated(2, ECSS_SEQUENCE_FLAGS); // sequence flags(not implemented) + report.appendEnumerated(2, ECSS_SEQUENCE_FLAGS); // sequence flags report.appendBits(14, 0); // packet sequence count(not implemented) report.appendEnum16(errorCode); // error code