From 7136e4cff08c91cfb89250effe1abb85128a620e Mon Sep 17 00:00:00 2001 From: Grigoris Pavlakis <grigpavl@ece.auth.gr> Date: Wed, 21 Nov 2018 22:58:56 +0200 Subject: [PATCH] Move important stuff from second todo into notes --- src/Services/ParameterService.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Services/ParameterService.cpp b/src/Services/ParameterService.cpp index de68fd19..e2db44d4 100644 --- a/src/Services/ParameterService.cpp +++ b/src/Services/ParameterService.cpp @@ -44,13 +44,13 @@ Message ParameterService::reportParameterIds(Message paramIds) { * @return A TM[20, 2] packet containing the parameter ID * * @todo Implement binary tree search for the lookup in order to be faster when the number of - * params inevitably rises (NOT URGENT) - * - * @todo Find a way to update the number of IDs so that exported packets contain only valid data - * (Done, but method is kludgy (clones the message and figures out separately the number of - * valid IDs). Should be enough for now. + * params inevitably rises (NOT URGENT YET) * - * NOTE: Everything apart from the setting data is uint16 (setting data are uint32 for now) + * NOTES: + * Method for valid ID counting is a hack (clones the message and figures out the number + * separately, due to message access being non-random). Should be enough for now. + * + * Everything apart from the setting data is uint16 (setting data are uint32 for now) */ Message reqParam(20, 2, Message::TM, 1); // empty TM[20, 2] parameter report message -- GitLab