From 80f026ccfa235cca6ae985043b8943265c6729c2 Mon Sep 17 00:00:00 2001
From: Grigoris Pavlakis <grigpavl@ece.auth.gr>
Date: Thu, 12 Mar 2020 20:51:04 +0200
Subject: [PATCH] Fix clang-tidy
---
src/Services/ParameterService.cpp | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/Services/ParameterService.cpp b/src/Services/ParameterService.cpp
index aef2fd05..9040a65e 100644
--- a/src/Services/ParameterService.cpp
+++ b/src/Services/ParameterService.cpp
@@ -13,17 +13,14 @@ ParameterService::ParameterService() {
void ParameterService::addNewParameter(uint16_t id, ParameterBase* param, const char* flags) {
if (paramsList.full()) {
ErrorHandler::reportInternalError(ErrorHandler::InternalErrorType::MapFull);
- return;
}
else {
if (paramsList.find(id) == paramsList.end()) {
param->setFlags(flags);
paramsList.insert(std::make_pair(id, param));
- return;
}
else {
ErrorHandler::reportInternalError(ErrorHandler::InternalErrorType::ExistingParameterId);
- return;
}
}
}
@@ -67,7 +64,7 @@ void ParameterService::reportParameterIds(Message& paramIds) {
reqParam.appendUint16(validIds); // append the number of valid IDs
- for (auto i: validParams) {
+ for (auto const& i: validParams) {
reqParam.appendUint16(i.first); // append the parameter ID
reqParam.appendString(i.second); // and its value
}
--
GitLab