From 970fb716a17e777cfa59c88b25d530f1e959c32a Mon Sep 17 00:00:00 2001
From: Dimitrios Stoupis <dimitris.apple@gmail.com>
Date: Wed, 20 Mar 2019 15:26:58 +0000
Subject: [PATCH] Required todo statements added for future reference
---
src/Services/TimeBasedSchedulingService.cpp | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/Services/TimeBasedSchedulingService.cpp b/src/Services/TimeBasedSchedulingService.cpp
index cf829ab2..34ab4073 100644
--- a/src/Services/TimeBasedSchedulingService.cpp
+++ b/src/Services/TimeBasedSchedulingService.cpp
@@ -99,7 +99,7 @@ void TimeBasedSchedulingService::timeShiftAllActivities(Message &request) {
return leftSide.requestReleaseTime <
rightSide.requestReleaseTime;
});
-
+ // todo: Define what the time format is going to be
int32_t relativeOffset = request.readSint32(); // Get the relative offset
if ((releaseTimes.first->requestReleaseTime + relativeOffset) <
(current_time + ECSS_TIME_MARGIN_FOR_ACTIVATION)) {
@@ -214,7 +214,6 @@ void TimeBasedSchedulingService::detailReportAllActivities(Message &request) {
report.appendString(msgParser.convertTCToStr(activity.request));
}
storeMessage(report); // Save the report
- request.resetRead(); // todo: define if this statement is required
}
void TimeBasedSchedulingService::detailReportActivitiesByID(Message &request) {
@@ -264,11 +263,10 @@ void TimeBasedSchedulingService::detailReportActivitiesByID(Message &request) {
// todo: append sub-schedule and group ID if they are defined
report.appendUint16(static_cast<uint16_t >(matchedActivities.size()));
for (const auto &match : matchedActivities) {
- report.appendUint32(match->requestReleaseTime);
+ report.appendUint32(match->requestReleaseTime); // todo: Replace with the time parser
report.appendString(msgParser.convertTCToStr(match->request));
}
storeMessage(report); // Save the report
- request.resetRead(); // todo: define if this statement is required
}
void TimeBasedSchedulingService::summaryReportActivitiesByID(Message &request) {
@@ -324,5 +322,4 @@ void TimeBasedSchedulingService::summaryReportActivitiesByID(Message &request) {
report.appendUint16(match->requestID.sequenceCount);
}
storeMessage(report); // Save the report
- request.resetRead(); // todo: define if this statement is required
}
--
GitLab