From a8f83fa8b9c09087fc7b425d2d4880023bcdbb6f Mon Sep 17 00:00:00 2001
From: athatheocsd <athatheo@csd.auth.gr>
Date: Thu, 10 Jan 2019 04:50:00 +0200
Subject: [PATCH] Well scratch my last commit message
---
src/Services/EventActionService.cpp | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/Services/EventActionService.cpp b/src/Services/EventActionService.cpp
index 7446ed78..478c7943 100644
--- a/src/Services/EventActionService.cpp
+++ b/src/Services/EventActionService.cpp
@@ -23,9 +23,7 @@ void EventActionService::addEventActionDefinitions(Message message) {
eventActionDefinitionArray[index].enabled = true;
eventActionDefinitionArray[index].applicationId = message.readEnum16();
eventActionDefinitionArray[index].eventDefinitionID = message.readEnum16();
- // Tests pass with message.dataSize - 3, message.dataSize - 4, but not
- // message.dataSize - 5
- if (message.dataSize - 4 > ECSS_EVENT_SERVICE_STRING_SIZE) { // TODO: Fix this
+ if (message.dataSize - 4 > ECSS_EVENT_SERVICE_STRING_SIZE) { // TODO: Should this be >=
ErrorHandler::reportInternalError(ErrorHandler::InternalErrorType::MessageTooLarge);
} else {
char data[ECSS_EVENT_SERVICE_STRING_SIZE];
--
GitLab