From ad3d468b5b13944d9cd47f2fd927ca50faa4eac3 Mon Sep 17 00:00:00 2001
From: kpetridis <petridkon@gmail.com>
Date: Thu, 28 Apr 2022 20:25:11 +0300
Subject: [PATCH] Made all todos, issues
---
inc/Helpers/AllMessageTypes.hpp | 1 -
src/Services/RealTimeForwardingControlService.cpp | 2 --
2 files changed, 3 deletions(-)
diff --git a/inc/Helpers/AllMessageTypes.hpp b/inc/Helpers/AllMessageTypes.hpp
index 76080056..136a6447 100644
--- a/inc/Helpers/AllMessageTypes.hpp
+++ b/inc/Helpers/AllMessageTypes.hpp
@@ -15,7 +15,6 @@
/**
* Namespace containing all the message types for every service type.
- * todo: needs to be updated after the implementation of the remaining ecss services.
*/
namespace AllMessageTypes {
extern etl::vector<uint8_t, ECSSMaxReportTypeDefinitions> st01Messages;
diff --git a/src/Services/RealTimeForwardingControlService.cpp b/src/Services/RealTimeForwardingControlService.cpp
index 1cb6ee93..73ef3a4e 100644
--- a/src/Services/RealTimeForwardingControlService.cpp
+++ b/src/Services/RealTimeForwardingControlService.cpp
@@ -134,7 +134,6 @@ void RealTimeForwardingControlService::addReportTypesToAppProcessConfiguration(M
}
for (uint8_t j = 0; j < numOfServices; j++) {
- // todo: check if service type is valid.
uint8_t serviceType = request.readUint8();
uint8_t numOfMessages = request.readUint8();
@@ -153,7 +152,6 @@ void RealTimeForwardingControlService::addReportTypesToAppProcessConfiguration(M
if (not checkMessage(request, applicationID, serviceType, messageType)) {
continue;
}
- // todo: check if message type is valid.
auto appServicePair = std::make_pair(applicationID, serviceType);
applicationProcessConfiguration.definitions[appServicePair].push_back(
messageType);
--
GitLab