From adaa87c8d5c8621394b28ab5eee06d409ab2cf66 Mon Sep 17 00:00:00 2001
From: kongr45gpen <electrovesta@gmail.com>
Date: Tue, 13 Aug 2019 23:49:06 +0300
Subject: [PATCH] Move some TODOs as doxygen comments
Apply suggestion to src/Helpers/TimeAndDate.cpp
---
inc/Services/TimeBasedSchedulingService.hpp | 5 +++--
src/Helpers/TimeAndDate.cpp | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/inc/Services/TimeBasedSchedulingService.hpp b/inc/Services/TimeBasedSchedulingService.hpp
index e748b25f..575b0359 100644
--- a/inc/Services/TimeBasedSchedulingService.hpp
+++ b/inc/Services/TimeBasedSchedulingService.hpp
@@ -76,13 +76,14 @@ private:
*
* @details All scheduled activities must contain the request they exist for, their release
* time and the corresponding request identifier.
+ *
+ * @todo If we decide to use sub-schedules, the ID of that has to be defined
+ * @todo If groups are used, then the group ID has to be defined here
*/
struct ScheduledActivity {
Message request; ///< Hold the received command request
RequestID requestID; ///< Request ID, characteristic of the definition
uint32_t requestReleaseTime = 0; ///< Keep the command release time
- // todo: If we decide to use sub-schedules, the ID of that has to be defined
- // todo: If groups are used, then the group ID has to be defined here
};
/**
diff --git a/src/Helpers/TimeAndDate.cpp b/src/Helpers/TimeAndDate.cpp
index 29903d17..54a17b6b 100644
--- a/src/Helpers/TimeAndDate.cpp
+++ b/src/Helpers/TimeAndDate.cpp
@@ -17,6 +17,7 @@ TimeAndDate::TimeAndDate(uint16_t year, uint8_t month, uint8_t day, uint8_t hour
ASSERT_INTERNAL((1 <= day) && (day <= 31), ErrorHandler::InternalErrorType::InvalidDate);
ASSERT_INTERNAL(hour < 24, ErrorHandler::InternalErrorType::InvalidDate);
ASSERT_INTERNAL(minute < 60, ErrorHandler::InternalErrorType::InvalidDate);
+ // Seconds can be equal to 60, to account for leap seconds.
ASSERT_INTERNAL(second <= 60, ErrorHandler::InternalErrorType::InvalidDate);
this->year = year;
--
GitLab