From c012d13d51872cc6ca2e2103207636ba4de3d129 Mon Sep 17 00:00:00 2001
From: Grigoris Pavlakis <grigpavl@ece.auth.gr>
Date: Sat, 2 Mar 2019 15:48:43 +0200
Subject: [PATCH] Prepare for replacement of if statements checking message
type with assertions and proper notification messages provided by
ErrorHandler
---
inc/Services/ParameterService.hpp | 1 +
src/Services/ParameterService.cpp | 6 ++----
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/inc/Services/ParameterService.hpp b/inc/Services/ParameterService.hpp
index cfdb8401..17d5aebc 100644
--- a/inc/Services/ParameterService.hpp
+++ b/inc/Services/ParameterService.hpp
@@ -2,6 +2,7 @@
#define ECSS_SERVICES_PARAMETERSERVICE_HPP
#include "Service.hpp"
+#include "ErrorHandler.hpp"
#include "etl/map.h"
#define CONFIGLENGTH 5
diff --git a/src/Services/ParameterService.cpp b/src/Services/ParameterService.cpp
index f9ea54f4..fb10078d 100644
--- a/src/Services/ParameterService.cpp
+++ b/src/Services/ParameterService.cpp
@@ -55,8 +55,7 @@ void ParameterService::reportParameterIds(Message paramIds) {
}
else {
- // generate failure of execution notification for ST[06]
- continue; // ignore the invalid ID
+ continue; // generate failure of execution notification (todo) for ST[06] & ignore
}
}
}
@@ -77,8 +76,7 @@ void ParameterService::setParameterIds(Message newParamValues) {
}
else {
- // generate failure of execution notification for ST[06]
- continue; // ignore the invalid ID
+ continue; // generate failure of execution notification (todo) for ST[06] & ignore
}
}
}
--
GitLab