diff --git a/inc/Services/MemoryManagementService.hpp b/inc/Services/MemoryManagementService.hpp index 5bf5a3dc4ad69b2f50c5fd68c7f5875767572dc8..5cd3c16da1f43a2f62d741553052dbae2eeb319c 100644 --- a/inc/Services/MemoryManagementService.hpp +++ b/inc/Services/MemoryManagementService.hpp @@ -4,7 +4,6 @@ #include <memory> #include <iostream> #include "Service.hpp" -#include "Services/RequestVerificationService.hpp" #include "Helpers/CRCHelper.hpp" #include "ErrorHandler.hpp" #include "Platform/STM32F7/MemoryAddressLimits.hpp" @@ -75,8 +74,6 @@ public: } rawDataMemorySubservice; private: - RequestVerificationService requestVerificationService; - /** * Check whether the provided address is valid or not, based on the defined limit values * diff --git a/src/Services/MemoryManagementService.cpp b/src/Services/MemoryManagementService.cpp index 5de493e887ded1131600891f39919b272cac33a8..05bd9bdfea50fb1de15ef10b3f8daf919d701c50 100644 --- a/src/Services/MemoryManagementService.cpp +++ b/src/Services/MemoryManagementService.cpp @@ -58,15 +58,9 @@ void MemoryManagementService::RawDataMemoryManagement::loadRawData(Message &requ ErrorHandler::reportError(request, ErrorHandler::ChecksumFailed); } } else { - // todo: Implement the fail report the correct way when all parameters known - mainService.requestVerificationService.failExecutionVerification( - request.packetType, true, 1, 1, 10, 6); ErrorHandler::reportError(request, ErrorHandler::ChecksumFailed); } } else { - // todo: The final implementation of exit on failure has to be well defined - mainService.requestVerificationService.failExecutionVerification( - request.packetType, true, 1, 1, 10, 6); ErrorHandler::reportError(request, ErrorHandler::ChecksumFailed); continue; // Continue to the next command } @@ -115,8 +109,6 @@ void MemoryManagementService::RawDataMemoryManagement::dumpRawData(Message &requ report.appendOctetString(readLength, readData); // Save the read data report.appendBits(16, CRCHelper::calculateCRC(readData, readLength)); } else { - mainService.requestVerificationService.failExecutionVerification(request.packetType, - true, 1, 1, 10, 6); ErrorHandler::reportError(request, ErrorHandler::AddressOutOfRange); } } @@ -166,8 +158,6 @@ void MemoryManagementService::RawDataMemoryManagement::checkRawData(Message &req report.appendUint16(readLength); // Save the read data report.appendBits(16, CRCHelper::calculateCRC(readData, readLength)); // Append CRC } else { - mainService.requestVerificationService.failExecutionVerification(request.packetType, - true, 1, 1, 10, 6); ErrorHandler::reportError(request, ErrorHandler::AddressOutOfRange); } }