From d793f46426a0c3dabd580c5a1a9b694303e63619 Mon Sep 17 00:00:00 2001
From: Dimitrios Stoupis <dimitris.apple@gmail.com>
Date: Tue, 4 Dec 2018 06:45:51 +0000
Subject: [PATCH] Remove unnecessary request verification service
---
inc/Services/MemoryManagementService.hpp | 3 ---
src/Services/MemoryManagementService.cpp | 10 ----------
2 files changed, 13 deletions(-)
diff --git a/inc/Services/MemoryManagementService.hpp b/inc/Services/MemoryManagementService.hpp
index 5bf5a3dc..5cd3c16d 100644
--- a/inc/Services/MemoryManagementService.hpp
+++ b/inc/Services/MemoryManagementService.hpp
@@ -4,7 +4,6 @@
#include <memory>
#include <iostream>
#include "Service.hpp"
-#include "Services/RequestVerificationService.hpp"
#include "Helpers/CRCHelper.hpp"
#include "ErrorHandler.hpp"
#include "Platform/STM32F7/MemoryAddressLimits.hpp"
@@ -75,8 +74,6 @@ public:
} rawDataMemorySubservice;
private:
- RequestVerificationService requestVerificationService;
-
/**
* Check whether the provided address is valid or not, based on the defined limit values
*
diff --git a/src/Services/MemoryManagementService.cpp b/src/Services/MemoryManagementService.cpp
index 5de493e8..05bd9bdf 100644
--- a/src/Services/MemoryManagementService.cpp
+++ b/src/Services/MemoryManagementService.cpp
@@ -58,15 +58,9 @@ void MemoryManagementService::RawDataMemoryManagement::loadRawData(Message &requ
ErrorHandler::reportError(request, ErrorHandler::ChecksumFailed);
}
} else {
- // todo: Implement the fail report the correct way when all parameters known
- mainService.requestVerificationService.failExecutionVerification(
- request.packetType, true, 1, 1, 10, 6);
ErrorHandler::reportError(request, ErrorHandler::ChecksumFailed);
}
} else {
- // todo: The final implementation of exit on failure has to be well defined
- mainService.requestVerificationService.failExecutionVerification(
- request.packetType, true, 1, 1, 10, 6);
ErrorHandler::reportError(request, ErrorHandler::ChecksumFailed);
continue; // Continue to the next command
}
@@ -115,8 +109,6 @@ void MemoryManagementService::RawDataMemoryManagement::dumpRawData(Message &requ
report.appendOctetString(readLength, readData); // Save the read data
report.appendBits(16, CRCHelper::calculateCRC(readData, readLength));
} else {
- mainService.requestVerificationService.failExecutionVerification(request.packetType,
- true, 1, 1, 10, 6);
ErrorHandler::reportError(request, ErrorHandler::AddressOutOfRange);
}
}
@@ -166,8 +158,6 @@ void MemoryManagementService::RawDataMemoryManagement::checkRawData(Message &req
report.appendUint16(readLength); // Save the read data
report.appendBits(16, CRCHelper::calculateCRC(readData, readLength)); // Append CRC
} else {
- mainService.requestVerificationService.failExecutionVerification(request.packetType,
- true, 1, 1, 10, 6);
ErrorHandler::reportError(request, ErrorHandler::AddressOutOfRange);
}
}
--
GitLab