diff --git a/inc/Services/ParameterService.hpp b/inc/Services/ParameterService.hpp index 0992043fe91237cc5e2a0c787487037f3c98a5a0..f0761bea2a11cb725f20c95d751ced978dc28983 100644 --- a/inc/Services/ParameterService.hpp +++ b/inc/Services/ParameterService.hpp @@ -16,7 +16,7 @@ /** * Generic parameter structure * PTC and PFC for each parameter shall be specified as in - * ECSS-ECSS-E-ST-70-41C, chapter 7.3 + * ECSS-E-ST-70-41C, chapter 7.3 */ struct Parameter { @@ -39,11 +39,10 @@ struct Parameter { */ class ParameterService : public Service { - +private: Parameter paramsList[CONFIGLENGTH]; // CONFIGLENGTH is just a dummy number for now, this should be statically set - - // RequestVerificationService rvs; // request verification service for error reporting + static uint16_t numOfValidIds(Message idMsg); //count the valid ids in a given TC[20, 1] public: ParameterService(); diff --git a/src/Services/ParameterService.cpp b/src/Services/ParameterService.cpp index 49e1de6b7db56b2ffc32d7d6d0b54a33a98b433f..4fa0e1b200d6981a97852c4b8e199d8063940d8f 100644 --- a/src/Services/ParameterService.cpp +++ b/src/Services/ParameterService.cpp @@ -9,8 +9,6 @@ #endif -uint16_t numOfValidIds(Message idMsg); //count the valid ids in a given TC[20, 1] - ParameterService::ParameterService() { #ifdef DEMOMODE /** @@ -119,7 +117,7 @@ void ParameterService::setParameterIds(Message newParamValues) { } } -uint16_t numOfValidIds(Message idMsg) { +uint16_t ParameterService::numOfValidIds(Message idMsg) { idMsg.readPosition = 0; // start reading from the beginning of the idMsg object