Fix build issues after master merging

inc/Services/RequestVerificationService.hpp

@@ -28,7 +28,7 @@ public:
 	 * of the telecommand packet that accepted successfully
 	 *
 	 */
-	void successAcceptanceVerification(Message &request);
+	void successAcceptanceVerification(const Message &request);
 
 	/**
 	 * TM[1,2] failed acceptance verification report
@@ -37,7 +37,7 @@ public:
 	 * The data is actually some data members of Message that contain the basic
 	 * info of the telecommand packet that failed to be accepted
 	 */
-	void failAcceptanceVerification(Message &request);
+	void failAcceptanceVerification(const Message &request);
 
 
 	/**
@@ -48,7 +48,7 @@ public:
 	 * telecommand packet that executed successfully
 	 *
  	 */
-	void successExecutionVerification(Message &request);
+	void successExecutionVerification(const Message &request);
 
 	/**
 	 * TM[1,8] failed completion of execution verification report
@@ -58,7 +58,7 @@ public:
 	 * telecommand packet that failed to be executed
 	 *
 	 */
-	void failExecutionVerification(Message &request);
+	void failExecutionVerification(const Message &request);
 
 	/**
 	 * TM[1,10] failed routing verification report
@@ -68,7 +68,7 @@ public:
 	 * telecommand packet that failed the routing
 	 *
  	 */
-	void failRoutingVerification(Message &request);
+	void failRoutingVerification(const Message &request);
 
 	/**
 	 * It is responsible to call the suitable function that execute the proper subservice. The
@@ -79,7 +79,7 @@ public:
 	 *
 	 * @todo Error handling for the switch() in the implementation of this execute function
 	 */
-	void execute(Message &message);
+	void execute(const Message &message);
 
 	/**
 	 *  The purpose of this instance is to access the execute function of this service when a

Catch2 @ 77f29c2f

-Subproject commit 62460fafe6b54c3173bc5cbc46d05a5f071017ff
+Subproject commit 77f29c2f1cde8bd2e17f06cc04092b990d2acc2c

src/ErrorHandler.cpp

@@ -9,42 +9,21 @@ static RequestVerificationService requestVerificationService;
 
 template<>
 void ErrorHandler::reportError(const Message &message, AcceptanceErrorType errorCode) {
-	requestVerificationService.failAcceptanceVerification(
-		message.packetType,
-		true,
-		message.applicationId,
-		ECSS_SEQUENCE_FLAGS,
-		message.packetSequenceCount,
-		static_cast<uint16_t>(errorCode)
-	);
+	requestVerificationService.failAcceptanceVerification(message);
 
 	logError(message, errorCode);
 }
 
 template<>
 void ErrorHandler::reportError(const Message &message, ExecutionErrorType errorCode) {
-	requestVerificationService.failExecutionVerification(
-		message.packetType,
-		true,
-		message.applicationId,
-		ECSS_SEQUENCE_FLAGS,
-		message.packetSequenceCount,
-		static_cast<uint16_t>(errorCode)
-	);
+	requestVerificationService.failExecutionVerification(message);
 
 	logError(message, errorCode);
 }
 
 template<>
 void ErrorHandler::reportError(const Message &message, RoutingErrorType errorCode) {
-	requestVerificationService.failRoutingVerification(
-		message.packetType,
-		true,
-		message.applicationId,
-		ECSS_SEQUENCE_FLAGS,
-		message.packetSequenceCount,
-		static_cast<uint16_t>(errorCode)
-	);
+	requestVerificationService.failRoutingVerification(message);
 
 	logError(message, errorCode);
 }

src/Services/RequestVerificationService.cpp

 #include "Services/RequestVerificationService.hpp"
 #include "Message.hpp"
 
-void RequestVerificationService::successAcceptanceVerification(Message &request) {
+void RequestVerificationService::successAcceptanceVerification(const Message &request) {
 	// TM[1,1] successful acceptance verification report
 
 	Message report = createTM(1);
@@ -17,7 +17,7 @@ void RequestVerificationService::successAcceptanceVerification(Message &request)
 }
 
 void
-RequestVerificationService::failAcceptanceVerification(Message &request) {
+RequestVerificationService::failAcceptanceVerification(const Message &request) {
 	// TM[1,2] failed acceptance verification report
 
 	Message report = createTM(2);
@@ -33,7 +33,7 @@ RequestVerificationService::failAcceptanceVerification(Message &request) {
 	storeMessage(report);
 }
 
-void RequestVerificationService::successExecutionVerification(Message &request) {
+void RequestVerificationService::successExecutionVerification(const Message &request) {
 	// TM[1,7] successful completion of execution verification report
 
 	Message report = createTM(7);
@@ -49,7 +49,7 @@ void RequestVerificationService::successExecutionVerification(Message &request)
 }
 
 void
-RequestVerificationService::failExecutionVerification(Message &request) {
+RequestVerificationService::failExecutionVerification(const Message &request) {
 	// TM[1,8] failed completion of execution verification report
 
 	Message report = createTM(8);
@@ -66,7 +66,7 @@ RequestVerificationService::failExecutionVerification(Message &request) {
 }
 
 void
-RequestVerificationService::failRoutingVerification(Message &request) {
+RequestVerificationService::failRoutingVerification(const Message &request) {
 	// TM[1,10] failed routing verification report
 
 	Message report = createTM(10);
@@ -82,7 +82,7 @@ RequestVerificationService::failRoutingVerification(Message &request) {
 	storeMessage(report);
 }
 
-void RequestVerificationService::execute(Message &message) {
+void RequestVerificationService::execute(const Message &message) {
 	switch (message.messageType) {
 		case 1:
 			successAcceptanceVerification(message);