Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
E
ECSS Services
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Deploy
Releases
Package registry
Model registry
Operate
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
AcubeSat-OBC
ECSS Services
Commits
adaa87c8
Unverified
Commit
adaa87c8
authored
5 years ago
by
kongr45gpen
Browse files
Options
Downloads
Patches
Plain Diff
Move some TODOs as doxygen comments
Apply suggestion to src/Helpers/TimeAndDate.cpp
parent
a5b58582
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
inc/Services/TimeBasedSchedulingService.hpp
+3
-2
3 additions, 2 deletions
inc/Services/TimeBasedSchedulingService.hpp
src/Helpers/TimeAndDate.cpp
+1
-0
1 addition, 0 deletions
src/Helpers/TimeAndDate.cpp
with
4 additions
and
2 deletions
inc/Services/TimeBasedSchedulingService.hpp
+
3
−
2
View file @
adaa87c8
...
@@ -76,13 +76,14 @@ private:
...
@@ -76,13 +76,14 @@ private:
*
*
* @details All scheduled activities must contain the request they exist for, their release
* @details All scheduled activities must contain the request they exist for, their release
* time and the corresponding request identifier.
* time and the corresponding request identifier.
*
* @todo If we decide to use sub-schedules, the ID of that has to be defined
* @todo If groups are used, then the group ID has to be defined here
*/
*/
struct
ScheduledActivity
{
struct
ScheduledActivity
{
Message
request
;
///< Hold the received command request
Message
request
;
///< Hold the received command request
RequestID
requestID
;
///< Request ID, characteristic of the definition
RequestID
requestID
;
///< Request ID, characteristic of the definition
uint32_t
requestReleaseTime
=
0
;
///< Keep the command release time
uint32_t
requestReleaseTime
=
0
;
///< Keep the command release time
// todo: If we decide to use sub-schedules, the ID of that has to be defined
// todo: If groups are used, then the group ID has to be defined here
};
};
/**
/**
...
...
This diff is collapsed.
Click to expand it.
src/Helpers/TimeAndDate.cpp
+
1
−
0
View file @
adaa87c8
...
@@ -17,6 +17,7 @@ TimeAndDate::TimeAndDate(uint16_t year, uint8_t month, uint8_t day, uint8_t hour
...
@@ -17,6 +17,7 @@ TimeAndDate::TimeAndDate(uint16_t year, uint8_t month, uint8_t day, uint8_t hour
ASSERT_INTERNAL
((
1
<=
day
)
&&
(
day
<=
31
),
ErrorHandler
::
InternalErrorType
::
InvalidDate
);
ASSERT_INTERNAL
((
1
<=
day
)
&&
(
day
<=
31
),
ErrorHandler
::
InternalErrorType
::
InvalidDate
);
ASSERT_INTERNAL
(
hour
<
24
,
ErrorHandler
::
InternalErrorType
::
InvalidDate
);
ASSERT_INTERNAL
(
hour
<
24
,
ErrorHandler
::
InternalErrorType
::
InvalidDate
);
ASSERT_INTERNAL
(
minute
<
60
,
ErrorHandler
::
InternalErrorType
::
InvalidDate
);
ASSERT_INTERNAL
(
minute
<
60
,
ErrorHandler
::
InternalErrorType
::
InvalidDate
);
// Seconds can be equal to 60, to account for leap seconds.
ASSERT_INTERNAL
(
second
<=
60
,
ErrorHandler
::
InternalErrorType
::
InvalidDate
);
ASSERT_INTERNAL
(
second
<=
60
,
ErrorHandler
::
InternalErrorType
::
InvalidDate
);
this
->
year
=
year
;
this
->
year
=
year
;
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment